[flashrom] [PATCH] Make the laptop warning less scary if unsure

[Stefan Tauner]

On Sat, 03 Sep 2011 14:47:58 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> > what do you think about this patch/idea?
> >     
> 
> I really like the ability to tell flashrom "this is not a laptop", full
> ACK from me for the idea. We just need to make sure the implementation
> will work as intended.

imho the code in the patch works as intended in its scope. the -p
problem is already in the existing code and has nothing to do with his
per se. as you said it can trigger various nasty things in other parts
of flashrom already.

the (minor) thing idwer pointed out about the patch itself is..
self-quote: "the force_I_want_a_brick will override the other one
(which is then neither used nor checked). i think that is ok..."
i.e. even if the user is told to use the this_is_not_a_laptop-
parameter, it can use force_I_want_a_brick and it will work. i would
even say this is a feature :)

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner