[flashrom] [PATCH] spi25: get rid of unneccessary line breaks (on failed probes)

Uwe Hermann uwe at hermann-uwe.de
Sat Sep 3 17:43:53 CEST 2011


On Mon, Aug 22, 2011 at 01:07:50PM +0200, Stefan Tauner wrote:
> ---
> not sure if this is correct for all execution paths, but it fixes the
> output of a probe on my thinkpad. i have looked a bit around to find
> examples of code that this patch would break and found none though.
> 
> without this patch:
> Probing for Spansion S25FL064A, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x3017
> Probing for SST SST25LF040A, 512 kB: Invalid OPCODE 0xab, will not execute.
> 
> Probing for SST SST25LF080A, 1024 kB: Invalid OPCODE 0xab, will not execute.
> 
> Probing for SST SST25VF010.REMS, 128 kB: Invalid OPCODE 0x90, will not execute.
> 
> Probing for SST SST25VF016B, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x3017
> 
> with this patch:
> Probing for Spansion S25FL064A, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x3017
> Probing for SST SST25LF040A, 512 kB: Invalid OPCODE 0xab, will not execute.
> Probing for SST SST25LF080A, 1024 kB: Invalid OPCODE 0xab, will not execute.
> Probing for SST SST25VF010.REMS, 128 kB: Invalid OPCODE 0x90, will not execute.
> Probing for SST SST25VF016B, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x3017
> 
> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>

Untested, but I can't see any obvious problems either.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org




More information about the flashrom mailing list