[flashrom] [PATCH] board_enable: Make it8712f_gpio_set generic

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Mon Nov 14 14:01:54 CET 2011

On Tue, 23 Aug 2011 14:35:36 +0200
Stefan Tauner <stefan.tauner at student.tuwien.ac.at> wrote:

> This looks suspiciously like intel_ich_gpio_set.
> Based on that, add board enables for the ASUS P5N-D and P5N-E SLI.
> This was tested by Guillaume Poirier-Morency on a P5N-D:
> http://www.flashrom.org/pipermail/flashrom/2011-August/007706.html
> Signed-off-by: Joshua Roys <roysjosh at gmail.com>
> Acked-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> ---
> i have made a few changes:
>  - renamed functions to our usual scheme
>  - marked the P5E (board enable) as not tested
>  - use a pointer to the config entry to access it instead of its index
> the latter together with the goto makes the execution flow more obvious imho.
> if anyone asks this is of course also
> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> but i don't deserve it imo.

as discussed on IRC i have committed this in r1466 with a few further
modifications (better and earlier input validation).

Kind regards/Mit freundlichen Grüßen, Stefan Tauner

More information about the flashrom mailing list