[flashrom] [PATCH] Unsignify lengths and addresses in chip functions and structs
stefan.tauner at student.tuwien.ac.at
Sun Nov 13 23:43:25 CET 2011
On Sun, 13 Nov 2011 23:23:39 +0100
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
> > - /* Delay after "enter/exit ID mode" commands in microseconds. */
> > - int probe_timing;
> > + /* Delay after "enter/exit ID mode" commands in microseconds.
> > + * NB: negative values have special meanings, see TIMING_* below.
> > + */
> > + signed int probe_timing;
> AFAICS the C standard defines that int is always signed. The only
> exception is char which is implementation-defined. Please kill signed
> here, but keep your comment.
this was on purpose to make it really, really obvious to anyone reading
the code that this is not just an unsigned delay (even if he ignores
the comment). :)
because you know... one could think that and change it in a patch which
gets acked and committed by accident and produce really odd bugs ;)
will review the other comments later, thanks!
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
More information about the flashrom