[flashrom] [patch] move ich_init_opcodes() call back to where it was before r1461

[Stefan Tauner]

On Sat, 12 Nov 2011 23:43:40 +0000
"Jonathan A. Kollasch" <jakllsch at kollasch.net> wrote:

> ich_init_opcodes() needs to be called after ichspi_lock is set.
> 
> Signed-off-by: Jonathan A. Kollasch <jakllsch at kollasch.net>
> 

thanks jonathan for that patch, but this wont work as it should due to
ich_missing_opcodes.
i have prepared the attached patch already and will commit it as soon as
carldani had time to discuss it.
it changes the output which might not what we want:
[…]
SPIBAR = 0xfed1c000 + 0x3800
0x04: 0xe008 (HSFS)
HSFS: FDONE=0, FCERR=0, AEL=0, BERASE=1, SCIP=0, FDOPSS=1, FDV=1, FLOCKDN=1
WARNING: SPI Configuration Lockdown activated.
Reading OPCODES... done
0x06: 0x3f00 (HSFC)
HSFC: FGO=0, FCYCLE=0, FDBC=63, SME=0
0x08: 0x00003000 (FADDR)
0x50: 0x00000a0b (FRAP)
[…]

the problem is "Reading OPCODES... done" which is quite unexpected in
the middle of the register outputs...(?)

another option would be to make ichspi_lock a function or macro.
performance is probably not an issue(?) and we would avoid such ordering
problems.

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ichspi-fix-ich_init_opcodes-calls-in-ich_init_spi.patch
Type: text/x-patch
Size: 1745 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20111113/038f6085/attachment.patch>