[flashrom] [PATCH 06/11] add missing ICH9 register macros and use them to eliminate magic numbers

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Sun May 29 02:24:15 CEST 2011


On Sun, 29 May 2011 02:10:49 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> Am 28.05.2011 05:38 schrieb Stefan Tauner:
> > Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> >  	minaddr &= BBAR_MASK;
> >  	switch (spi_programmer->type) {
> >  	case SPI_CONTROLLER_ICH7:
> >  	case SPI_CONTROLLER_VIA:
> >  		ichspi_bbar = mmio_readl(ich_spibar + 0x50) & ~BBAR_MASK;
> > -		if (ichspi_bbar)
> > +		if (ichspi_bbar) {
> >  			msg_pdbg("Reserved bits in BBAR not zero: 0x%04x",
> >  				 ichspi_bbar);
> > +		}
> >   
> 
> Was that hunk intentional? We usually avoid {} for single-command if blocks.
that is ok if it is not split in multiple lines due to the line limit.
in this case it is not "single line" and i think it is more readable
this way. but i can drop it if you disagree...

> 
> Why did FDOC disappear?

because that is the control register for accessing ich-mapped
descriptors with no useful information.
see later patches how it is used ;)

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list