[flashrom] [PATCH] eliminate magic numbers indicating maximum column sizes in print_supported_chipsets and print_supported_boards_helper

Uwe Hermann uwe at hermann-uwe.de
Fri May 20 10:11:33 CEST 2011


On Thu, May 19, 2011 at 02:44:19AM +0200, Stefan Tauner wrote:
> without this the magic numbers need to be kept in sync with the maximum length of the
> strings printed in the corresponding column. if not an overflow and a nasty ' '-storm occurs
> on executing flashrom -L.
> 
> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>

I only did a quick code review, but the output looks good.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org




More information about the flashrom mailing list