[flashrom] [PATCH] Lock printing for AMIC A25* and Atmel AT25*

[Carl-Daniel Hailfinger]

Thanks for the review, committed in r1316 with minor changes.

If I forgot to fix/change anything, please holler.

Am 07.05.2011 23:04 schrieb Stefan Tauner:
> On Sat, 07 May 2011 22:33:13 +0200
> Carl-Daniel Hailfinger<c-d.hailfinger.devel.2006 at gmx.net>  wrote:
>
> making the printing independent from probing is of course the right
> thing to do.
> can we rename the printlock field of the struct or at least change the
> comment indicating that is does not only _lock_ printing but chip
> status printing? or do you want to use the field for getting/printing
> generic lock layout data for each chip later? i would think having a
> method to _additionally_ print out the status bits would be useful in
> that case anyway?
>    

To be honest, my longterm goal is .read_status_and_locks and 
.change_locks (no, not those names, but I wanted to illustrate my goal). 
A global walk_locking_info_struct_array() function would be used to 
print the info gathered in .read_status_and_locks.
Chip status register info would be printed raw at debug level and 
verbose at spew level. Chip locking (with numeric addresses for affected 
regions, adjacent regions merged) would be printed at debug level.


>>> the same applies to:
>>>
>>>        
>>>> 	msg_cdbg("Chip status register: Status Register Write
>>>> Disable " "(SRWD) is %sset\n", (status&   (1<<   7)) ? "" : "not ");
>>>>
>>>>          
>>> in a25.c (only).
>>>
>>>        
>> Hm yes. I was not sure whether moving a single line to a separate
>> function is a good idea or not.
>>      
> well... spi_prettyprint_status_register_atmel_at25_srpl ;)
>    

Right. Do you want to change that or should I?

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/