[flashrom] [PATCH] serprog SPI support

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Mon May 16 15:42:49 CEST 2011


hey urja!

coding style: the tabs are certainly to be used according to the
official coreboot rules, but the rest is just my personal view. i am
not sure how the other devs think about it.

opbuf/delay: what's the use of this in spi mode? i dont see why this is
needed at all.

patch split: dunno. it might be overlooked if the rest is not
committed. therefore i explicitly mentioned this in case someone with
commit rights reads the review ;)
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list