[flashrom] [PATCH 1/3] Factor out SPI write/read chunking wrappers.
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Thu May 5 20:47:17 CEST 2011
Hi Michael,
thanks for your patch!
Am 05.05.2011 03:04 schrieb Michael Karcher:
> diff --git a/dummyflasher.c b/dummyflasher.c
> index d818a84..b6e67db 100644
> --- a/dummyflasher.c
> +++ b/dummyflasher.c
> @@ -507,12 +507,6 @@ int dummy_spi_send_command(unsigned int writecnt, unsigned int readcnt,
> return 0;
> }
>
> -int dummy_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len)
> -{
> - /* Maximum read length is unlimited, use 64kB. */
> - return spi_read_chunked(flash, buf, start, len, 64 * 1024);
> -}
> -
> int dummy_spi_write_256(struct flashchip *flash, uint8_t *buf, int start, int len)
> {
> return spi_write_chunked(flash, buf, start, len,
>
Any reason you didn't kill dummy_write_256()? If you kill it, please
remove it from programmer.h and adjust SPI_CONTROLLER_DUMMY in spi.c
accordingly. Thanks.
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the flashrom
mailing list