[flashrom] [PATCH 0/7] Hello, Support for Atmel's AT25F series and some small stuff

[Carl-Daniel Hailfinger]

Hi Stefan,

thanks for your patches!

Auf 14.03.2011 21:40, Stefan Tauner schrieb:
> Stefan Tauner (7):
>    whitespace, documentation and other small stuff
>    The AT25F512B is quite different from the other (yet unsupported)
>      chips in the     AT25F* familiy, so rename 512B-specific stuff.
>    generify spi_rdid to allow passing different opcodes. This is needed
>      to add support     for Atmel's AT25F series.
>    Add support for Atmel's AT25F series of SPI flash chips.     This
>      includes a new probing method (probe_spi_rdid_at25f), block erase
>      method     (spi_block_erase_62),
>      spi_prettyprint_status_register_at25f and
>      spi_disable_blockprotect_at25f.
>    add support for 8086:1076 (82541GI) to nicintel_spi.c
>    use getpagesize() to determine physmap's length in nicintel_spi.c
>    check if write enable is really set in nicintel_spi_init (and minor
>      comment changes).
>    

I will review the patches individually, but a small comment beforehand:
There are some pending patches for AT25* already, and we should make 
sure to avoid conflicts between those patches and your patches. I'll dig 
up those AT25* patches again and repost them for review.
Given that you looked at AT25* in detail, maybe you can review those 
older AT25 changes?

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/