[flashrom] [PATCH] serprog SPI support
stefan.tauner at student.tuwien.ac.at
Tue Jun 21 13:15:23 CEST 2011
On Mon, 16 May 2011 18:16:03 +0300
Urja Rannikko <urjaman at gmail.com> wrote:
> Add SPI support to serprog protocol.
> Signed-off-by: Urja Rannikko <urjaman at gmail.com>
> Changed stuff mostly according to review ... and an e-mail that
> arrived while I was writing this.
> Added the optimized SPI read function for serprog that I had already
> done, -r time for 1Mbyte 18s -> 11s.
> > the other opbuf stuff should also be optional imho, but if this is done
> > we probably would like to change the functions using it because they
> > often bail out via exit if they read a NAK e.g. sp_flush_stream
> Now it is mandatory for non-SPI, but optional for SPi.
> If the programmer is SPI-only we should not get any other than delay
> calls that would generate opbuf-using commands,
> will test for this later and report.
i will port my own avr-based programmer to your serprog implementation
and review it on the way so that we can commit it soon. do you have
other pending, local changes for this that i should know about? have you
tested your stuff further?
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
More information about the flashrom