[flashrom] [PATCH 2/3] fix and add a few chipset_enables entries

[Stefan Tauner]

On Sat, 18 Jun 2011 15:12:15 +0200
Uwe Hermann <uwe at hermann-uwe.de> wrote:

> On Mon, Jun 13, 2011 at 10:44:43PM +0200, Stefan Tauner wrote:
> > Signed-off-by: Idwer Vollering <vidwer at gmail.com>
> > Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> > ---
> >  chipset_enable.c |   12 +++++++++---
> >  1 files changed, 9 insertions(+), 3 deletions(-)
> > 
> > diff --git a/chipset_enable.c b/chipset_enable.c
> > index 3a2febc..5907b86 100644
> > --- a/chipset_enable.c
> > +++ b/chipset_enable.c
> > @@ -1115,8 +1115,8 @@ const struct penable chipset_enables[] = {
> > […]
> 
> >  	{0x8086, 0x2480, OK, "Intel", "ICH3-S",		enable_flash_ich_4e},
> >  	{0x8086, 0x248c, OK, "Intel", "ICH3-M",		enable_flash_ich_4e},
> >  	{0x8086, 0x24c0, OK, "Intel", "ICH4/ICH4-L",	enable_flash_ich_4e},
> >  	{0x8086, 0x24cc, OK, "Intel", "ICH4-M",		enable_flash_ich_4e},
> 
> >  	{0x8086, 0x24d0, OK, "Intel", "ICH5/ICH5R",	enable_flash_ich_4e},
> > +//	{0x8086, 0x24dc, NT, "Intel", "ICH5/ICH5R",	enable_flash_ich_4e}, /* http://www.intel.com/assets/pdf/datasheet/252516.pdf */
> 
> This is a duplicate entry? I cannot find 0x24dc in the datasheet, 0x24d0
> is the correct device ID for ICH5/ICH5R. I'd rather drop this entry for now
> (and the comment).
me neither, dropped. idwer do you have any idea how this came in?

> > […]
> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

thanks. engineering samples were changed to match the existing line for the ich9 ES.
committed in r1343

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner