[flashrom] [PATCH 6/6] add support for Intel Hardware Sequencing

David Hendricks dhendrix at google.com
Thu Jun 16 01:23:27 CEST 2011


fyi, the following small errors are made in multiple times (copy + paste?)
in ichspi.c

On Tue, Jun 14, 2011 at 3:20 PM, Stefan Tauner <
stefan.tauner at student.tuwien.ac.at> wrote:

> +       msg_pdbg("Erasing %d bytes starting at 0x%06x\n", len, addr);
> +
> +       hsfc = REGREAD16(ICH9_REG_HSFC);
> +       /* make sure FDONE, FCERR, AEL are cleared by writing 1 to them */
> +       REGWRITE16(ICH9_REG_HSFC, hsfc);
>

Should be done using HSFS.

On Tue, Jun 14, 2011 at 3:20 PM, Stefan Tauner <
stefan.tauner at student.tuwien.ac.at> wrote:

> +       hsfs = REGREAD16(ICH9_REG_HSFS);
> +       if (!timeout) {
> +               msg_perr("timeout!\n");
> +               prettyprint_ich9_reg_hsfs(hsfs);
> +               prettyprint_ich9_reg_hsfc(hsfs);
>

The second prettyprint should take hsfc. Don't forget to read hsfc before
going into the if() statement (like you did with hsfs).


-- 
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110615/4373a560/attachment.html>


More information about the flashrom mailing list