[flashrom] [PATCH 08/12] simplify ich_set_bbar

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Mon Jun 13 20:31:21 CEST 2011

On Mon, 13 Jun 2011 19:24:55 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> Am 08.06.2011 04:55 schrieb Stefan Tauner:
> > ~10 lines less, documenting better what the differences are (i.e. offset of BBAR only).
> >
> > Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> >   
> Nice cleanup!
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

ahem! :)

because of idwer's remark that "msg_pdbg("Reserved bits in BBAR not
zero: 0x%04x"..." should get a \n (thx!), i reviewed that patch again
and noticed that it is quite broken.

in the original code the real bbar is read from the register and
checked for reserved bits before we try to set the requested min
address. i somehow missed that, sorry. :/

the new, attached patch has following changes:
 - check for reserved bits
 - output 8 hex characters instead of 4 (i.e. 32b instead of 16b)
 - add \n to the message above

Kind regards/Mit freundlichen Grüßen, Stefan Tauner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-2.0-simplify-ich_set_bbar.patch
Type: text/x-patch
Size: 2787 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110613/61e07c49/attachment.patch>

More information about the flashrom mailing list