[flashrom] [PATCH] Add Olimex ARM-USB-TINY as an FT2232 SPI Programmer
Pete Batard
pbatard at gmail.com
Sat Jun 11 00:31:03 CEST 2011
On 2011.06.10 19:21, Stefan Tauner wrote:
> in the table above all programmers are marked ok although they were not
> all tested...
> i am quoting my last mail: "please add them and just mark them as NT in
> the array".
Ah, sorry, I completely overlooked that one. Thanks for the reminder.
> i also do not recognize the reason to order the devices like that
Well, first from Olimex came the ARM-USB-OCD (PID 3), then came the
ARM-USB-TINY (PID 4), so that's our start. But then when the H versions
came along, Olimex curiously "released" the OCD-H (PID 2B) after the
TINY-H (PID 2A). It only felt more natural to me to have both the H and
non H versions listed in the same order in the source, but if you want
to reorganize them around as you see fit, just go ahead.
> regarding the man page patch:
>> -can be any of
>> +can be one of
> how is that better (non-native speaker here...)?
Non native speaker either, but I think (feel) "any of" is better applied
to very short lists, whereas "one of" is better applied to long ones,
and our list has grown long. As the matter above, just a matter of
individual perception.
>> Please note that the External_flashers/programmers section of the
>> Supported_hardware wiki [2] should probably also be updated to only
>> mention FT2232/FT4232 (without the H), as we now have evidence that
>> FT2232D/FT2232L are working just as well for SPI access.
> why not drop the 'H' altogether? or list the other versions there too
> (like in "FT2232D/H/L" or similar)?
Considering that I have just found out that there also exists HL and HQ
versions of the above chips, I think it's safer to go without the suffix
there, so I amended the man page.
> if you resubmit the patches, could you please merge them?
Here you go. Signed-off-by: Pete Batard <pbatard at gmail.com>
Regards,
/Pete
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ft2232_spi_v3.diff
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110610/abc5bf43/attachment.ksh>
More information about the flashrom
mailing list