[flashrom] [PATCH 01/12] improve macros for SSFS and SSFC bits
stefan.tauner at student.tuwien.ac.at
Thu Jun 9 05:34:24 CEST 2011
On Thu, 09 Jun 2011 00:42:12 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
> One additional comment...
> Am 08.06.2011 04:55 schrieb Stefan Tauner:
> > - /* clear error status registers */
> > - temp32 |= (SSFS_CDS + SSFS_FCERR);
> > + /* Clear cycle done and cycle error status registers */
> > + temp32 |= (SSFS_FDONE + SSFS_FCERR);
> Please use | instead of + here.
i have posted this patch set only because dhendrix tried to build the
previous one including the squash (11b) patch as mentioned in my 0/12
mail. i have not taken care of the comments you made to the 4.0 version
of the series (which included the above request already).
i am aware of that and will incorporate everything you said previously
of course before committing! some of those were already acked by
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
More information about the flashrom