[flashrom] [PATCH] automatically round address ranges requested from physmap_common to page boundaries

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Wed Jun 1 04:35:03 CEST 2011

On Mon, 30 May 2011 02:45:44 +0200
Stefan Tauner <stefan.tauner at student.tuwien.ac.at> wrote:

> this patch also changes the display width of all addresses in physmap.c to 16 hex characters.
> FIXME: what about unmappings?
> munmap is safe.
> djgpp's __dpmi_free_physical_address_mapping: unknown.
> DirectHW's unmap_physical: unknown.
> FIXME: jakllsch suggested using PRIx64 instead of x, because it's more portable

FIXME: in the case we can not map and 'mayfail' is true we should return
ERROR_PTR instead of ERROR_PTR + diff

Kind regards/Mit freundlichen Grüßen, Stefan Tauner

More information about the flashrom mailing list