[flashrom] [patch] atavia

Jonathan A. Kollasch jakllsch at kollasch.net
Wed Jul 27 02:10:16 CEST 2011


On Wed, Jul 27, 2011 at 02:03:10AM +0300, Tadas Slotkus wrote:
> 
> > Okay, so it still doesn't work.  The 6421 is being clever, and coping
> > with that is really something I don't care to do, at least right now.
> > 
> > 	Jonathan Kollasch
> 
> Hi, thanks for the patch. Could you tell us more about the problems you
> encountered? I may have some time after summer to play with that
> programmer, so some info would be appreciated :)

Doesn't work with some chips.  Seems 1MiB chips seem to work almost
universally, but not smaller ones.

> Is 'continue' required?

No.

> msg_pdbg should be printed only if failed or
> should be spew? (generates 3*Chip_size_in_bytes number of lines in
> writing at least)

Dunno, it hasn't bothered me yet.
 
> What about bool type usage in this project? We are using integers
> here :)

Uh, I could care less, I sort of assumed we were C99.

	Jonathan Kollasch




More information about the flashrom mailing list