[flashrom] [PATCH] Add support for the GIGABYTE GA-8SIMLH board.

[Michael Karcher]

Am Montag, den 25.07.2011, 01:01 +0200 schrieb Stefan Tauner:
> since it has apparently worked
> (http://paste.flashrom.org/view.php?id=733) and looks fine otherwise,
> this is
> Acked-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
Thanks for the Ack. This is r1385.

> two minor nitpicks:
> 
> > +	{0x1039, 0x0651, 0x1039, 0x0651,  0x1039, 0x7012, 0x1458, 0xa002, "^GA-8SIMLH$",NULL, NULL,           P3, "GIGABYTE",    "GA-8SIMLH",             0,   OK, sis_gpio0_raise_and_w836xx_memw},
> 
> the second device is the sound card, which could presumably be disabled.
> there is only one other device with a gigabyte vendor id: 1458:5004
> (usb2.0 controller). not sure if that would be better, just wanted to
> mention it.
Good catch, adjusted. I missed the USB device for some reason.

> >  	B("GIGABYTE",	"GA-8IRML",		1, "http://www.gigabyte.com/products/product-page.aspx?pid=1343", NULL),
> > +	B("GIGABYTE",	"GA-8SIMLH",		1, "http://www.gigabyte.com/products/product-page.aspx?pid=1399", NULL),
> >  	B("GIGABYTE",	"GA-8PE667 Ultra 2",	1, "http://www.gigabyte.com/products/product-page.aspx?pid=1607", NULL),
> P < S, so the new one should be below the GA-8PE667.
Sorry, I was too quick here, and committed after just fixing the first
one. I think this should go in the next cleanup commit or so, or should
we fix that immediately?

Regards,
  Michael Karcher