[flashrom] [PATCH] fix output for multiple found flash chips

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Mon Jul 25 00:32:16 CEST 2011


On Fri, 24 Jun 2011 19:03:52 +0200
Stefan Tauner <stefan.tauner at student.tuwien.ac.at> wrote:

> -  missing quotes
> -  missing commas
> 
> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> ---
>  cli_classic.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/cli_classic.c b/cli_classic.c
> index 59096a0..aba6edf 100644
> --- a/cli_classic.c
> +++ b/cli_classic.c
> @@ -373,9 +373,10 @@ int cli_classic(int argc, char *argv[])
>  	}
>  
>  	if (chipcount > 1) {
> -		printf("Multiple flash chips were detected:");
> -		for (i = 0; i < chipcount; i++)
> -			printf(" %s", flashes[i].name);
> +		printf("Multiple flash chips were detected: \"%s\"",
> +			flashes[0].name);
> +		for (i = 1; i < chipcount; i++)
> +			printf(", \"%s\"", flashes[i].name);
>  		printf("\nPlease specify which chip to use with the -c <chipname> option.\n");
>  		programmer_shutdown();
>  		exit(1);

since no one else has reviewed this yet and it is fairly trivial, i will
add it with my next "tested stuff" commit

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list