[flashrom] [commit] r1381 - trunk

repository service svn at flashrom.org
Sun Jul 24 17:34:57 CEST 2011


Author: stefanct
Date: Sun Jul 24 17:34:56 2011
New Revision: 1381
URL: http://flashrom.org/trac/flashrom/changeset/1381

Log:
ichspi.c: do not print PBR[3] for ICH7 because it does not exist

intel document 307013 (ICH7 datasheet) section 21.1.9 does only
define PBR[0] (at SPIBAR + 60h) to PBR[2] (SPIBAR + 68h). SPIBAR + 6Ch
and following are not defined, but we were printing them as PBR[3]
anyway. i could not find any references to PBR[3] in documentation of
other related chips (NM10, atom e6xx) either, hence kill it.

Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Modified:
   trunk/ichspi.c

Modified: trunk/ichspi.c
==============================================================================
--- trunk/ichspi.c	Thu Jul 21 23:21:04 2011	(r1380)
+++ trunk/ichspi.c	Sun Jul 24 17:34:56 2011	(r1381)
@@ -1263,7 +1263,7 @@
 			     mmio_readl(ich_spibar + 0x58));
 		msg_pdbg("0x5c: 0x%08x (OPMENU+4)\n",
 			     mmio_readl(ich_spibar + 0x5c));
-		for (i = 0; i < 4; i++) {
+		for (i = 0; i < 3; i++) {
 			int offs;
 			offs = 0x60 + (i * 4);
 			msg_pdbg("0x%02x: 0x%08x (PBR%d)\n", offs,




More information about the flashrom mailing list