[flashrom] [PATCH] Kill unused "log" argument of count_usable_erasers()

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Mon Jul 4 09:29:10 CEST 2011


On Sun, 3 Jul 2011 16:56:40 +0200
"Sylvain 'ythier' Hitier" <sylvain.hitier at gmail.com> wrote:

> Kill unused "log" argument of count_usable_erasers().
> 
> Signed-off-by: Sylvain "ythier" Hitier <sylvain.hitier at gmail.com>
> 
> Index: flashrom.c
> ===================================================================
> --- flashrom.c	(revision 1362)
> +++ flashrom.c	(working copy)
> @@ -713,9 +713,8 @@
>  	return extract_param(&programmer_param, param_name, ",");
>  }
>  
> -/* Returns the number of well-defined erasers for a chip.
> - * The log parameter controls output. */
> -static unsigned int count_usable_erasers(const struct flashchip *flash, int log)
> +/* Returns the number of well-defined erasers for a chip. */
> +static unsigned int count_usable_erasers(const struct flashchip *flash)
>  {
>  	unsigned int usable_erasefunctions = 0;
>  	int k;
> @@ -1511,7 +1510,7 @@
>  	int k, ret = 0;
>  	uint8_t *curcontents;
>  	unsigned long size = flash->total_size * 1024;
> -	unsigned int usable_erasefunctions = count_usable_erasers(flash, 0);
> +	unsigned int usable_erasefunctions = count_usable_erasers(flash);
>  
>  	msg_cinfo("Erasing and writing flash chip... ");
>  	curcontents = (uint8_t *) malloc(size);
> @@ -1831,7 +1830,7 @@
>  				return 1;
>  			msg_cerr("Continuing anyway.\n");
>  		}
> -		if(count_usable_erasers(flash, 0) == 0) {
> +		if(count_usable_erasers(flash) == 0) {
>  			msg_cerr("flashrom has no erase function for this "
>  				 "flash chip.\n");
>  			return 1;

thanks for spotting this. no idea why i put the parameter in there
anyway... :/

Acked-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
and committed in r1364
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner




More information about the flashrom mailing list