[flashrom] [PATCH] Autodetect target processor architecture

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Jul 1 00:07:28 CEST 2011


Am 30.06.2011 23:26 schrieb Andrew Morgan:
> On 29/06/11 03:26, Carl-Daniel Hailfinger wrote:
>> Autodetect target processor architecture.
>> Enable architecture dependent compilation of individual sub-drivers for
>> the internal programmer.
>>
>> With this patch, you no longer have to edit the Makefile to compile the
>> internal driver on MIPS/ARM/...
>>
>> TODO: arch.h is not suitable for inclusion in a .c/.h file because of
>> its last line. Any ideas how to change that (move arch.h as "here
>> document" into the Makefile, use other trickery like more #ifdefs)?
> Patch tested on PowerPC Linux.

Thanks!


> Flashrom still needs to be compiled with 'CONFIG_RAYER_SPI=0
> CONFIG_NIC3COM=0 CONFIG_NICREALTEK=0 CONFIG_SATAMV=0 make' but then it
> works. I assume those variables can be automatically set based on the
> value of ARCH at a later date.

Right, that would make sense.


> Checking for a C compiler... found.
> ARCH is "ppc"
> ...
>
> $ uname -a
>
> Linux mini 2.6.38-8-powerpc #42-Ubuntu Mon Apr 11 03:41:36 UTC 2011
> ppc ppc ppc GNU/Linux
>
>
> ps. Your post mentions ARM but arch.h doesn't.

Yes, David had the problem of incompatible internal drivers on ARM, and
if this patch gets merged, he can simply extend it with ARM definitions
and have his problems solved.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list