[flashrom] [PATCH] do something useful with the dediprog LEDs

Stefan Reinauer reinauer at google.com
Fri Jan 28 10:03:01 CET 2011


* Mathias Krause <mathias.krause at secunet.com> [110128 09:31]:
> >> Thanks for the patch. Albeit it would be good to have a "noleds" option
> >> to disable the functionality because we don't know if it breaks older
> >> firmware versions.
> > 
> > All changes added, except this one. Instead the updated version
> > explicitly support older firmware versions.
> 
> Thanks! Looks like a better solution to the problem. Albeit I found two
> (read: one and a half) more hunks to complain about ;)

Nice :-) Thanks for the review.

> Acked-by: Mathias Krause <mathias.krause at secunet.com>

Went in as r1257.





More information about the flashrom mailing list