[flashrom] [PATCH 2/5] Add deferred -i processing

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Dec 25 01:17:24 CET 2011


Hi Stefan,

minor commit log nitpicks only.

As first line of the changelog, use this instead for better
searchability of the changelog:
Add deferred --image processing

Am 24.12.2011 01:35 schrieb Stefan Tauner:
> The general idea and most of the code is stolen from chromiumos:

The general idea and most of the code are based on the following
commits in the chromiumos flashrom tree:



> 8fc0740356ca15d02fb1c65ab43b10844f148c3b
> bb9049c66ca55e0dc621dd2c70b5d2cb6e5179bf
> Signed-off-by: Louis Yung-Chieh Lo <yjlou at chromium.org>
>
> and the main part:
> d0ea9ed71e7f86bb8e8db2ca7c32a96de25343d8
> Signed-off-by: David Hendricks <dhendrix at chromium.org>
>
> My implementation does not defer the processing until doit(), but after the

s/My/This/


> argument parsing loop only (doit() should not contain argument checks).
>
> This allows to specify -i and -l parameters in any order.
>
> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
> Acked-by: David Hendricks <dhendrix at google.com>

You already have an ack, go ahead.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list