[flashrom] [PATCH 1/5] layout: change return type and name of find_next_included_romentry

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Dec 25 01:08:34 CET 2011


Am 24.12.2011 01:35 schrieb Stefan Tauner:
>  - rename from find_next_included_romentry to get_next_included_romentry
>  - return a pointer to a rom_entry instead of just its index
>
> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>

The changelog only describes what you're doing, but not the reason why.
If you add a short statement about the reason (readability improvement,
whatever) to the changelog, and if you change
if (entry == NULL) {
to
if  (!entry) {
this is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list