[flashrom] New flash chip, AT49F010

Andrew Morgan ziltro at ziltro.com
Wed Aug 31 02:52:42 CEST 2011


On 30/08/11 23:25, Stefan Tauner wrote:

> review of the AT49F010 patch follows:
>> Index: flashchips.c
>> ===================================================================
>> --- flashchips.c	(revision 1422)
>> +++ flashchips.c	(working copy)
>> @@ -2218,6 +2218,30 @@
>>
>>   	{
>>   		.vendor		= "Atmel",
>> +		.name		= "AT49F010",
> 		.name		= "AT49(H)F010",
> The H version is just a faster version (but with same VCC).
>
Are you suggesting I change the name to include (H)? If so does AT49F020 
have an H version too and should that be changed? If it wants to be 
changed what should flashchips.h have for the name?

>> +		.bustype	= BUS_PARALLEL,
>> +		.manufacture_id	= ATMEL_ID,
>> +		.model_id	= ATMEL_AT49F010,
>> +		.total_size	= 128,
>> +		.page_size	= 128,
> should probably be 256 for now (semantics are different for each chip
> driver for parallel chips afaik and it does not matter for jedec
> routines iirc. NB: page_size is in bytes, so syncing it with total_size
> does not make sense.)...
>
Ok, changed. I didn't know where to find information on what to set 
page_size, feature_bits or probe_timing to.


> this chip and also the 2 Mb and 4 Mb versions support a boot block
> protection that can be detected by software. it would be nice to add
> a .printlock function to do this and inform the user. i have seen the
> scheme before. Maybe there is already code in flashrom... but it is not
> that important.
I've looked at the patch mentioned in your later messages, and modified 
w39.c and chipdrivers.h, and added a .printlock = line to the AT49F010. 
The code compiled and ran and it told me the boot block lock was not 
active. This was just a test so I have left this out of the attached 
patch. I didn't do any tests to see if the printlock code affected 
read/write at all.

> Adding the 4 Mb version OTOH is trivial (ID 0x13) and would be
> appreciated. Nevertheless after addressing the in-line comments this
> patch is:
> Acked-by: Stefan Tauner<stefan.tauner at student.tuwien.ac.at>
>
> do you have commit rights?

I do not. Updated patch attached. I hope I got all the changes. :)

If I get a chance and can find datasheets I'll have a go at adding the 
larger AT49F chips.

-- 

Andrew.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: flashrom-AT49F010-mk2.patch
Type: text/x-patch
Size: 1342 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110831/59b8c072/attachment.patch>


More information about the flashrom mailing list