[flashrom] [PATCH] Fix printing of the Boot BIOS Straps on Intel chipsets

[Uwe Hermann]

On Wed, Aug 17, 2011 at 06:17:45AM +0200, Stefan Tauner wrote:
> defining all those arrays is not very elegant, but i think it is at least very
> readable this way.

Yep, pretty good solution IMHO, I would have done the same.


> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

I cross-checked the datasheets and didn't spot any errors (ICH7-10,
NM10, EP*, 5/6 series).

ICH6 and lower, ESB*, and 3100 series and probably others don't have
GCS, thus no need to list/mention them here (which you didn't).


> +	case 7:
> +		/* EP80579 may need further changes, but this is the least
> +		 * intrusive way to get correct BOOT Strap printing without
> +		 * changing the rest of its code path) */
                                                      ^
                                          Missing full stop here.


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org