[flashrom] [PATCH]add AMD hudson support

QingPei Wang wangqingpei at gmail.com
Fri Aug 26 03:56:42 CEST 2011


you are right, it's 0x1022. new patch attached~~~



Best wishes
Wang Qing Pei
Phone: 86+018930528086


On Fri, Aug 26, 2011 at 5:22 AM, Uwe Hermann <uwe at hermann-uwe.de> wrote:

> Hi,
>
> On Thu, Aug 25, 2011 at 11:06:12PM +0800, QingPei Wang wrote:
> > The HUDSON has different vendor & device id than SBx00. The ids are got
> > by lspci.
> > Signed-off-by: Wang Qing Pei <wangqingpei at gmail.com>
>
> Thanks for the patch, we'll merge it soonish, but please see below for
> some questions.
>
>
> > Index: chipset_enable.c
> > ===================================================================
> > --- chipset_enable.c    (revision 1419)
> > +++ chipset_enable.c    (working copy)
> > @@ -1052,6 +1052,7 @@
>
> > +    {0x1002, 0x780e, OK, "AMD", "HUDSON",        enable_flash_sb600},
>
> Shouldn't this be 0x1022 (AMD instead of ATI ID) here?
>
> Also, did you test the chipset-enable on real hardware? Otherwise we
> should probably commit this as "NT" (not tested) instead of "OK".
>
> Please post a log of "./flashrom -V" with the patch applied if you own
> some test hardware, thanks!
>
>
> Uwe.
> --
> http://hermann-uwe.de     | http://sigrok.org
> http://randomprojects.org | http://unmaintained-free-software.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110826/023ea478/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_hudson_support.patch
Type: text/x-patch
Size: 1220 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110826/023ea478/attachment.patch>


More information about the flashrom mailing list