[flashrom] [PATCH 2/7] Add deferred -i processing

David Hendricks dhendrix at google.com
Fri Aug 19 23:55:20 CEST 2011


Oops, disregard that last message. I was looking at find_romentry() and
indeed it makes sense to return a negative value to indicate error since it
returns an index otherwise.

Acked-by: David Hendricks <dhendrix at google.com>

On Fri, Aug 19, 2011 at 2:53 PM, David Hendricks <dhendrix at google.com>wrote:

> Did you want to fix the inconsistent use of -1 instead of 1 as the return
> code for some functions?
>
> Other than that it looks good (i'm biased, of course :-))
>
> --
> David Hendricks (dhendrix)
> Systems Software Engineer, Google Inc.
>



-- 
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110819/e21cc462/attachment.html>


More information about the flashrom mailing list