[flashrom] [PATCH] Move the main() function from flashrom.c to cli_classic.c

Uwe Hermann uwe at hermann-uwe.de
Fri Aug 19 21:26:12 CEST 2011


On Fri, Aug 19, 2011 at 06:59:14PM +0300, Tadas Slotkus wrote:
> 
> > can't we just rename cli_classic to main and get rid of the wrapper
> > function? what's the purpose of it anyway?
> 
> I find it useful for globals init code (will post some patches in a day
> or few) :)

Not sure what you are referring to, but that should be easily doable in
the main() too then?

Updated patch attached.

As discussed with dhendrix on IRC, the Google/Chromium git tree will not
have a problem with this patch, they use a cli_mfg() which will get its own
main() and cli_mfg.o will be linked in the Makefile respectively
(instead of cli_classsic.o).

 
> Uwe, are you going to send patches removing exit() calls? :)

Maybe, yes, but feel free to send your own if you work on that, might
take a while here...


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flashrom_move_main2.patch
Type: text/x-diff
Size: 1606 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20110819/076f3e53/attachment.bin>


More information about the flashrom mailing list