[flashrom] [PATCH] Revert parts of r1397

[Stefan Tauner]

On Wed, 03 Aug 2011 01:51:37 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:

> Am 03.08.2011 01:27 schrieb Stefan Tauner:
> > On Wed, 03 Aug 2011 00:07:14 +0200
> > Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
> >> Index: flashrom-revert_r1397_partially/chipset_enable.c
> >> […]
> >> @@ -1028,8 +1029,8 @@
> >>  			flashbase = parx << 12;
> >>  		}
> >>  	} else {
> >> -		msg_pinfo("AMD Elan SC520 detected, but no BOOTCS. "
> >> -			  "Assuming flash at 4G\n");
> >> +		msg_pinfo("AMD Elan SC520 detected, but no BOOTCS. Assuming "
> >> +			  "flash at 4G.\n");
> >>  	}
> >>     
> > i also like breaking full sentences like it was done here previously.
> > filling the whole line just because we can does not mean it is useful.
> > reading one sentence per line is much more natural and as long as the
> > line count does not change i prefer it.
> >   
> 
> OK. My point was about adding a . at the end of the second sentence.

ah! missed that completely :)

> >   
> >> -static const struct board_pciid_enable *board_match_coreboot_name(
> >> -					const char *vendor, const char *part)
> >> +static const struct board_pciid_enable *board_match_coreboot_name(const char *vendor,
> >> +							    const char *part)
> >>     
> > both ugly :)
> >   
> 
> Indeed. Unfortunately I didn't find any beautiful solution which fit in
> 80 columns. The second line should be moved a bit to the right, but then
> we violate the 80 column limit even more.
> Ideas anyone?

yes, violate the §$&§$ 80 column limit (scnr :)
the function could be renamed... and board_pciid_enable is also a very
long name for a struct that's used a lot.

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner