[flashrom] [PATCH] improve output in case run_opcode fails

Michael Karcher flashrom at mkarcher.dialup.fu-berlin.de
Sat Apr 30 01:54:29 CEST 2011


Am Samstag, den 30.04.2011, 01:30 +0200 schrieb Stefan Tauner:
> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>

> +		if ((opcode->spi_type == SPI_OPCODE_TYPE_WRITE_WITH_ADDRESS) ||
> +		    (opcode->spi_type == SPI_OPCODE_TYPE_WRITE_NO_ADDRESS)) {
> +			msg_pspew("The data was:\n");
> +			int i;
please don't declare variables after statements.

> +			for(i=0; i<count; i++){
> +				msg_pspew("%3d: 0x%02x\n", i, data[i]);
> +			}
> +		}
>  	}
>  
>  	return result;

Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>

moved "int i" one line up and committed in r1291

Regards,
  Michael Karcher





More information about the flashrom mailing list