[flashrom] [PATCH] Remove erase_chip_stm50flw0x0x
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Fri Apr 15 01:30:33 CEST 2011
Am 09.03.2011 02:52 schrieb Michael Karcher:
> As the comment indicates, that function is not a chip erase function
> at all, but a function calling a block eraser in a loop. So it adds
> no extra value to what we already have in the block_eraser
> infrastructure.
>
> Furthermore, that function assumes a uniform sector size layout, but
> is referenced from flash chip with non-uniform sector size layout, which
> is just wrong.
>
Great, even more code killed. Thanks for your patch.
> Signed-off-by: Michael Karcher<flashrom at mkarcher.dialup.fu-berlin.de>
>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Please compile test, then commit.
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the flashrom
mailing list