[flashrom] [PATCH] Delay between probe and subsequent operations
c-d.hailfinger.devel.2006 at gmx.net
Wed Sep 15 11:58:14 CEST 2010
Delay between probe and subsequent operations.
Some flash chips need time to exit ID mode, and while we take care of
correct timing for the matching probe, subsequent probes may have
totally different timing, and that can lead to garbage responses from
the flash chip during the first accesses after the probe sequence is done.
Delay 100 ms between the last probe and any subsequent operation.
To ensure maximum correctness, we would have to reset the chip first in
case the last probe function left the chip in an undefined (non-read)
state. That will be possible once struct flashchip has a .reset function.
This fixes unstable erase/read/write for some flahs chips on nic3com and
possible other use cases as well.
Thanks to Maciej Pijanka for reporting the issue and testing patches.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
--- flashrom-delay_after_probes/cli_classic.c (Revision 1171)
+++ flashrom-delay_after_probes/cli_classic.c (Arbeitskopie)
@@ -456,5 +456,10 @@
if (write_it && !dont_verify_it)
verify_it = 1;
+ /* FIXME: We should issue an unconditional chip reset here. This can be
+ * done once we have a .reset function in struct flashchip.
+ * Give the chip time to settle.
return doit(flash, force, filename, read_it, write_it, erase_it, verify_it);
More information about the flashrom