[flashrom] [patch] partial write test script

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Oct 29 23:55:16 CEST 2010


On 29.10.2010 23:29, David Hendricks wrote:
> On Fri, Oct 29, 2010 at 2:27 PM, Carl-Daniel Hailfinger wrote:
>   
>> On 29.10.2010 22:51, David Hendricks wrote:
>>     
>>> When running the script, it seems that the added "$FLASHROM_PARAM" can
>>> get expanded incorrectly by the shell thus causing flashrom to barf
>>> when $FLASHROM_PARAM is empty. I suspect it quietly passes in "".
>>>
>>> The attached patch is a simple s/\"$FLASHROM_PARAM\"/${FLASHROM_PARAM}/g.
>>> This seems to work.
>>>
>>>       
>> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>     
>
> Signed-off-by: David Hendricks <dhendrix at google.com>
>   

Committed in r1219.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list