[flashrom] [PATCH] Fix offset calculation for partial SPI programming

[Carl-Daniel Hailfinger]

On 27.10.2010 21:06, Idwer Vollering wrote:
> With this patch applied: http://patchwork.coreboot.org/patch/2160/
>
> $ sudo ./flashrom -p nicintel_spi -V -w nicintel_spi.rom -c M25P10.RES
> flashrom v0.9.3-r1215 on FreeBSD 8.1-RELEASE (i386), built with libpci
> 3.1.7, GCC 4.2.1 20070719  [FreeBSD], little endian
> Calibrating delay loop... OK.
> Initializing nicintel_spi programmer
> Found "Intel 82541PI Gigabit Ethernet Controller" (8086:107c, BDF 01:03.0).
> Probing for ST M25P10.RES, 128 KB: probe_spi_res1: id 0x10
> Chip status register is 00
> Found chip "ST M25P10.RES" (128 KB, SPI) at physical address 0xfffe0000.
> Reading old flash chip contents...
> Erasing and writing flash chip... 
> Looking at blockwise erase function 0... trying... 
> 0x000000-0x007fff:W, 0x008000-0x00ffff:W, 0x010000-0x017fff:W,
> 0x018000-0x01ffff:S
> Done.
> Verifying flash... VERIFY FAILED at 0x00008000! Expected=0xc6,
> Read=0x15, failed byte count from 0x00000000-0x0001ffff: 0x8d75
> Your flash chip is in an unknown state.
>
>
> With http://patchwork.coreboot.org/patch/2188/
>
> $ sudo ./flashrom -p nicintel_spi -V -w nicintel_spi.rom -c M25P10.RES
> flashrom v0.9.3-r1216 on FreeBSD 8.1-RELEASE (i386), built with libpci
> 3.1.7, GCC 4.2.1 20070719  [FreeBSD], little endian
> Calibrating delay loop... OK.
> Initializing nicintel_spi programmer
> Found "Intel 82541PI Gigabit Ethernet Controller" (8086:107c, BDF 01:03.0).
> Probing for ST M25P10.RES, 128 KB: probe_spi_res1: id 0x10
> Chip status register is 00
> Found chip "ST M25P10.RES" (128 KB, SPI) at physical address 0xfffe0000.
> Reading old flash chip contents...
> Erasing and writing flash chip... 
> Looking at blockwise erase function 0... trying... 
> 0x000000-0x007fff:W, 0x008000-0x00ffff:W, 0x010000-0x017fff:W,
> 0x018000-0x01ffff:S
>
> Done.
> Verifying flash... VERIFIED.
>   

Great, so this patch indeed fixes the bug you were seeing.


>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>     
>
> Acked-by: Idwer Vollering <vidwer at gmail.com>
>   

Thanks, committed in r1217.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/