[flashrom] large file support
Stefan Reinauer
stepan at coreboot.org
Tue Oct 19 19:24:44 CEST 2010
* Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [101004 14:20]:
> I noticed that chipset_enable.c has #define _LARGEFILE64_SOURCE but it
> does not perform any open/seek, whereas other files (especially
> physmap.c) have no indication of large file support, yet they do use
> open/seek.
> Looking at the code history this seems to be an accident.
Yes it should be moved to physmap.c
> What's the correct way to get large file support, and do we need it at all?
> Image files will probably stay smaller than 16 MB, so I see no real
> problems there, but MSR support and physmap support may need this.
AFAICT it's not about the images, but I think it could be helpful when
mmapping areas of /dev/mem.
Stefan
More information about the flashrom
mailing list