[flashrom] [commit] r1202 - trunk

[repository service]

Author: hailfinger
Date: Fri Oct  8 13:03:02 2010
New Revision: 1202
URL: http://flashrom.org/trac/flashrom/changeset/1202

Log:
A lot of messages sent to flashrom at flashrom.org just have "flashrom -V"
as the subject. 
Ask people to include more information in the subject line to make life
easier for developers/supporters.

Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Modified:
   trunk/board_enable.c
   trunk/chipset_enable.c
   trunk/flashrom.c
   trunk/pcidev.c

Modified: trunk/board_enable.c
==============================================================================
--- trunk/board_enable.c	Fri Oct  8 02:37:55 2010	(r1201)
+++ trunk/board_enable.c	Fri Oct  8 13:03:02 2010	(r1202)
@@ -433,7 +433,9 @@
 			max_rom_decode.parallel = 1024 * 1024;
 			msg_pinfo("IT8705F with very unusual settings. Please "
 				  "send the output of \"flashrom -V\" to \n"
-				  "flashrom at flashrom.org to help us finish "
+				  "flashrom at flashrom.org with "
+				  "IT8705: your board name: flashrom -V\n"
+				  "as the subject to help us finish "
 				  "support for your Super I/O. Thanks.\n");
 			ret = 1;
 		} else if (tmp & 0x08) {
@@ -2097,7 +2099,8 @@
 		board = NULL;
 		} else {
 		        msg_pinfo("NOTE: Running an untested board enable procedure.\n"
-		               "Please report success/failure to flashrom at flashrom.org.\n");
+		               "Please report success/failure to flashrom at flashrom.org\n"
+		               "with your board name and SUCCESS or FAILURE in the subject.\n");
 		}
         }
 

Modified: trunk/chipset_enable.c
==============================================================================
--- trunk/chipset_enable.c	Fri Oct  8 02:37:55 2010	(r1201)
+++ trunk/chipset_enable.c	Fri Oct  8 13:03:02 2010	(r1202)
@@ -939,7 +939,9 @@
 	}
 out_msg:
 	msg_pinfo("Please send the output of \"flashrom -V\" to "
-		  "flashrom at flashrom.org to help us finish support for your "
+		  "flashrom at flashrom.org with\n"
+		  "your board name: flashrom -V as the subject to help us "
+		  "finish support for your\n"
 		  "chipset. Thanks.\n");
 
 	return ret;
@@ -1195,8 +1197,11 @@
 			continue;
 		if (ret != -2) {
 			msg_pinfo("WARNING: unexpected second chipset match: "
-			       "\"%s %s\"\nignoring, please report lspci and "
-			       "board URL to flashrom at flashrom.org!\n",
+				    "\"%s %s\"\n"
+				  "ignoring, please report lspci and board URL "
+				    "to flashrom at flashrom.org\n"
+				  "with 2CHIPSET: your board name in the "
+				    "subject line.\n",
 				chipset_enables[i].vendor_name,
 					chipset_enables[i].device_name);
 			continue;

Modified: trunk/flashrom.c
==============================================================================
--- trunk/flashrom.c	Fri Oct  8 02:37:55 2010	(r1201)
+++ trunk/flashrom.c	Fri Oct  8 13:03:02 2010	(r1202)
@@ -1314,7 +1314,8 @@
 {
 	msg_gerr("Your flash chip is in an unknown state.\n"
 		"Get help on IRC at irc.freenode.net (channel #flashrom) or\n"
-		"mail flashrom at flashrom.org!\n"
+		"mail flashrom at flashrom.org with FAILED: your board name in "
+		  "the subject line!\n"
 		"-------------------------------------------------------------"
 		  "------------------\n"
 		"DO NOT REBOOT OR POWEROFF!\n");
@@ -1496,8 +1497,8 @@
 			    "operations you tested (-V, -Vr,\n"
 			  "-Vw, -VE), and mention which mainboard or "
 			    "programmer you tested.\n"
-			  "Thanks for your help!\n"
-			  "===\n");
+			  "Please mention your board in the subject line. "
+			    "Thanks for your help!\n");
 	}
 }
 

Modified: trunk/pcidev.c
==============================================================================
--- trunk/pcidev.c	Fri Oct  8 02:37:55 2010	(r1201)
+++ trunk/pcidev.c	Fri Oct  8 13:03:02 2010	(r1202)
@@ -66,9 +66,11 @@
 
 		if (devs[i].status == NT) {
 			msg_pinfo("===\nThis PCI device is UNTESTED. Please "
-			       "report the 'flashrom -p xxxx' output \n"
-			       "to flashrom at flashrom.org if it works "
-			       "for you. Thank you for your help!\n===\n");
+				  "report the 'flashrom -p xxxx' output \n"
+				  "to flashrom at flashrom.org if it works "
+				  "for you. Please add the name of your\n"
+				  "PCI device to the subject. Thank you for "
+				  "your help!\n===\n");
 		}
 
 		return addr;