[flashrom] [PATCH] Compile fixes, update README

[Michael Karcher]

Am Freitag, den 08.10.2010, 04:30 +0200 schrieb Carl-Daniel Hailfinger:
> In detail:
> CONFIG_BITBANG_SPI was not selected if CONFIG_NICINTEL_SPI was on by
> default.
Patch is fine.

> Wiki output was missing all flash chips if CONFIG_INTERNAL was not selected.
Patch is fine if tested.

> ft2232_spi used possibly negative indices in the toupper() function/array.
Please also fix the other similar ctype issues in layout.c (two isprint
invocations) and serial.c (three tolower invocations) at that time, too.
The cast to "unsigned char" is exactly the right thing to do.

> Software requirements on non-Linux/FreeBSD/OpenBSD operating systems
> were missing.
See comment below.

> Non-x86 compilation does not work with the default programmer set, so
> list the make parameters which result in a working build.
I didn't verify the statement about what works on which architecture,
but if the statements are true, the text is fine.

> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
With the comments addressed, this is
Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>

> Index: flashrom-compilefixes/README
> ===================================================================
> --- flashrom-compilefixes/README	(revision 1201)
> +++ flashrom-compilefixes/README	(working copy)
> @@ -60,6 +60,11 @@
>   * devel/gmake
>   * sysutils/pciutils
>  
> +On other operating systems, you need the following software:
> +
> + * pciutils+libpci (if you want support for mainboard or PCI device flashing)
> + * libusb (if you want FT2232 or Dediprog support)
> +
The libusb requirements is general for all operating systems. I don't
really like it in the "other operating systems" section.

> +Processor architecture dependent features:
> +
> + On non-x86 architectures you have to disable a few programmers because they
> + use port-based I/O which is not directly available on non-x86. Please add
> + CONFIG_RAYER_SPI=no CONFIG_NIC3COM=no CONFIG_ATAHPT=no CONFIG_NICREALTEK=no \
> + CONFIG_NICNATSEMI=no
> + as parameters to the "make" invocation.
> + Besides that, the internal programmer is only supported on x86 and MIPS. On
> + other architectures, please add
> + CONFIG_INTERNAL=no
> + as parameter to the "make" invocation.
> +