[flashrom] [PATCH] Update man page

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Oct 7 03:45:00 CEST 2010


On 07.10.2010 02:56, Carl-Daniel Hailfinger wrote:
> On 06.10.2010 23:57, Uwe Hermann wrote:
>   
>> On Wed, Oct 06, 2010 at 01:19:47AM +0200, Carl-Daniel Hailfinger wrote:
>>   
>>     
>>> Update the man page to have correct info for the upcoming release.
>>>     
>>>       
>> Looks good.
>>
>> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
>>   
>>     
>
> Thanks, committed in r1197.
>
>
>   
>>> Should we mention all contributors with more than one patch? Should we
>>> restrict the author list to those who have substantial amounts of code
>>> in flashrom? Do we have to ask people if adding their email address to
>>> the manpage is OK?
>>>     
>>>       
>> I'd rather remove the whole list to be honest, it's tedious to keep
>> up-to-date and the manpage is the wrong place anyway IMHO (yes, I know
>> I'm the one who added it there in the first place).
>>
>> A short sentence like "Thanks to all contributors" is sufficient IMHO,
>> the details are in (C) lines in the source or in
>>
>>  svn log | grep -i Signed-off-by
>>
>> or similar.
>>   
>>     
>
> Mh. The early authors are missing in that list. You do have a point,
> though. Did you mean something like this?
>   

New version. Additional doc updates and fixes.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Index: flashrom-authors_programmer_doc/pcidev.c
===================================================================
--- flashrom-authors_programmer_doc/pcidev.c	(Revision 1199)
+++ flashrom-authors_programmer_doc/pcidev.c	(Arbeitskopie)
@@ -134,7 +134,7 @@
 
 	msg_pinfo("PCI devices:\n");
 	for (i = 0; devs[i].vendor_name != NULL; i++) {
-		msg_pinfo("%s %s [%02x:%02x]%s\n", devs[i].vendor_name,
+		msg_pinfo("%s %s [%04x:%04x]%s\n", devs[i].vendor_name,
 		       devs[i].device_name, devs[i].vendor_id,
 		       devs[i].device_id,
 		       (devs[i].status == NT) ? " (untested)" : "");
Index: flashrom-authors_programmer_doc/flashrom.8
===================================================================
--- flashrom-authors_programmer_doc/flashrom.8	(Revision 1199)
+++ flashrom-authors_programmer_doc/flashrom.8	(Arbeitskopie)
@@ -476,7 +476,10 @@
 .B "  http://www.flashrom.org/trac/flashrom/newticket"
 .sp
 or on the flashrom mailing list at
+.B "<flashrom at flashrom.org>"
 .sp
+We recommend to subscribe first at
+.sp
 .B "  http://www.flashrom.org/mailman/listinfo/flashrom"
 .sp
 Using flashrom on laptops is dangerous and may easily make your hardware
@@ -492,73 +495,75 @@
 .br
 Please see the individual files.
 .SH AUTHORS
-Andrew Morgan <ziltro at ziltro.com>
+Andrew Morgan
 .br
 Carl-Daniel Hailfinger
 .br
-Claus Gindhart <claus.gindhart at kontron.com>
+Claus Gindhart
 .br
-David Borg <borg.db at gmail.com>
+David Borg
 .br
-David Hendricks <dhendrix at google.com>
+David Hendricks
 .br
-Dominik Geyer <dominik.geyer at kontron.com>
+Dominik Geyer
 .br
 Eric Biederman
 .br
-Giampiero Giancipoli <gianci at email.it>
+Giampiero Giancipoli
 .br
-Helge Wagner <helge.wagner at ge.com>
+Helge Wagner
 .br
-Idwer Vollering <vidwer+flashrom at gmail.com>
+Idwer Vollering
 .br
-Joe Bao <Zheng.Bao at amd.com>
+Joe Bao
 .br
-Jörg Fischer <turboj at gmx.de>
+Jörg Fischer
 .br
-Joshua Roys <roysjosh at gmail.com>
+Joshua Roys
 .br
-Luc Verhaegen <libv at skynet.be>
+Luc Verhaegen
 .br
 Li-Ta Lo
 .br
-Markus Boas <ryven at ryven.de>
+Markus Boas
 .br
-Mattias Mattsson <vitplister at gmail.com>
+Mattias Mattsson
 .br
-Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
+Michael Karcher
 .br
-Nikolay Petukhov <nikolay.petukhov at gmail.com>
+Nikolay Petukhov
 .br
-Patrick Georgi <patrick.georgi at coresystems.de>
+Patrick Georgi
 .br
-Peter Lemenkov <lemenkov at gmail.com>
+Peter Lemenkov
 .br
-Peter Stuge <peter at stuge.se>
+Peter Stuge
 .br
-Reinder E.N. de Haan <lb_reha at mveas.com>
+Reinder E.N. de Haan
 .br
-Ronald G. Minnich <rminnich at gmail.com>
+Ronald G. Minnich
 .br
-Ronald Hoogenboom <ronald at zonnet.nl>
+Ronald Hoogenboom
 .br
-Sean Nelson <audiohacked at gmail.com>
+Sean Nelson
 .br
-Stefan Reinauer <stepan at coresystems.de>
+Stefan Reinauer
 .br
-Stefan Wildemann <stefan.wildemann at kontron.com>
+Stefan Wildemann
 .br
-Stephan Guilloux <stephan.guilloux at free.fr>
+Stephan Guilloux
 .br
-Steven James <pyro at linuxlabs.com>
+Steven James
 .br
-Uwe Hermann <uwe at hermann-uwe.de>
+Uwe Hermann
 .br
 Wang Qingpei
 .br
 Yinghai Lu
 .br
-some others 
+some others, please see the flashrom svn changelog for details.
+.br
+All authors can be reached via e-mail at <flashrom at flashrom.org>.
 .PP
 This manual page was written by Uwe Hermann <uwe at hermann-uwe.de>
 and Carl-Daniel Hailfinger.
Index: flashrom-authors_programmer_doc/print.c
===================================================================
--- flashrom-authors_programmer_doc/print.c	(Revision 1199)
+++ flashrom-authors_programmer_doc/print.c	(Arbeitskopie)
@@ -238,6 +238,7 @@
 	printf("\nSupported devices for the %s programmer:\n",
 	       programmer_table[PROGRAMMER_DUMMY].name);
 	/* FIXME */
+	printf("Dummy device, does nothing and logs all accesses\n");
 #endif
 #if CONFIG_NIC3COM == 1
 	printf("\nSupported devices for the %s programmer:\n",
@@ -286,21 +287,25 @@
 	printf("\nSupported devices for the %s programmer:\n",
 	       programmer_table[PROGRAMMER_SERPROG].name);
 	/* FIXME */
+	printf("All programmer devices speaking the serprog protocol\n");
 #endif
 #if CONFIG_BUSPIRATE_SPI == 1
 	printf("\nSupported devices for the %s programmer:\n",
 	       programmer_table[PROGRAMMER_BUSPIRATE_SPI].name);
 	/* FIXME */
+	printf("Dangerous Prototypes Bus Pirate\n");
 #endif
 #if CONFIG_DEDIPROG == 1
 	printf("\nSupported devices for the %s programmer:\n",
 	       programmer_table[PROGRAMMER_DEDIPROG].name);
 	/* FIXME */
+	printf("Dediprog SF100\n");
 #endif
 #if CONFIG_RAYER_SPI == 1
 	printf("\nSupported devices for the %s programmer:\n",
 	       programmer_table[PROGRAMMER_RAYER_SPI].name);
 	/* FIXME */
+	printf("RayeR parallel port programmer\n");
 #endif
 #if CONFIG_NICINTEL_SPI == 1
 	printf("\nSupported devices for the %s programmer:\n",


-- 
http://www.hailfinger.org/





More information about the flashrom mailing list