[flashrom] [PATCH] Board enable for Dell OptiPlex GX1 (try 2)

[Mattias Mattsson]

On Tue, Oct 5, 2010 at 22:21, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> On 05.10.2010 15:24, Carl-Daniel Hailfinger wrote:
>> On 04.09.2010 00:21, David Borg wrote:
>>
>>> Hi Mattias,
>>>
>>> It seems that patchwork didn't find your patch. I've updated it
>>> against r1151 and attached it here, in the hopes that it's now found
>>> :)
>>>
>>>
>>
>> Thanks for updating the patch.
>>
>>
>>
>>> In case it's needed, in addition to your original sign off, this is
>>> Signed-off-by: David Borg <borg.db at gmail.com>
>>>
>>>
>>
>> Usually not needed unless you modify the code.
>>
>>
>>
>>> On 16 August 2010 04:53, Mattias Mattsson <vitplister at gmail.com> wrote:
>>>
>>>
>>>> Add board enable for Dell OptiPlex GX1.
>>>>
>>>> This is a new version of an earlier patch.
>>>>
>>>> - Change matching PCI ID:s to ethernet and north bridge.
>>>>
>>>> - Truncate board name to "OptiPlex GX1" as this patch probably apply
>>>> to the whole series (they share the same vendor BIOS download).
>>>>
>>>> - Add URL to print.c
>>>>
>>>> - Marked board as OK. This was tested with an earlier version of
>>>> flashrom (r1092), but nothing has changed that affects this patch
>>>> (GPO30 is still always available on PIIX4).
>>>>
>>>> lspci output:
>>>> http://www.flashrom.org/pipermail/flashrom/2010-July/004042.html
>>>>
>>>> Signed-off-by: Mattias Mattsson <vitplister at gmail.com>
>>>>
>>>>
>>
>> Mattias, can you please credit the original reporter? And if he tested
>> it, add
>>
>> Tested-by: Joachim Ernst <joachim.ernst at web.de>
>>
>
> Sorry, my fault. I thought a report from last year had triggered this
> board enable. I was talking about
> http://www.flashrom.org/pipermail/flashrom/2009-July/000207.html
> So please ignore the Tested-by suggestion.
>
>> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>
>
> My ack still stands, though.

Thanks, committed as r1191


-mattias