[flashrom] [PATCH] Faster Dediprog writes

Richard A. Smith richard at laptop.org
Tue Nov 23 01:16:52 CET 2010


On 11/22/2010 06:54 PM, Carl-Daniel Hailfinger wrote:
> On 18.11.2010 16:37, Richard Smith wrote:
>> On Wed, Nov 17, 2010 at 11:53 PM, Carl-Daniel Hailfinger
>> <c-d.hailfinger.devel.2006 at gmx.net>  wrote:
>>
>>> Please note that the write speedup only applies to chips which have SPI
>>> page write (i.e. chips using spi_chip_write_256).
>>>
>>> Tests appreciated.
>>>
>>> Signed-off-by: Carl-Daniel Hailfinger<c-d.hailfinger.devel.2006 at gmx.net>
>>>
>>
>> I had to tweak the   if (writecnt>  5) {} clause to allow for the
>> larger size but other than that this Works For Me. It drops the
>> program time on my 128k part to 30 seconds.  Thats quite a bit better
>> than the 20 minutes it used to take.
>>
>> I also verified that chunk sizes larger than 12 fail but I didn't try
>> any values between 1 and 12.
>>
>
> Thanks for testing! New patch follows. If I get an ack, I'll commit.
>
> Add chunked write ability to the Dediprog SF100 driver.
>
> Please note that the write speedup only applies to chips which have SPI
> page write (i.e. chips using spi_chip_write_256).
>
> This is a quick fix for write speed until I get around to implementing
> full bulk SPI write support.
>
> Tests appreciated.

Acked-by: Richard A. Smith  <richard at laptop.org>

-- 
Richard A. Smith  <richard at laptop.org>
One Laptop per Child




More information about the flashrom mailing list