[flashrom] [PATCH] Real partial writes

David Hendricks dhendrix at google.com
Tue Nov 2 04:28:58 CET 2010


On Mon, Nov 1, 2010 at 8:09 PM, Carl-Daniel Hailfinger <
c-d.hailfinger.devel.2006 at gmx.net> wrote:

> On 02.11.2010 04:01, David Hendricks wrote:
> > I think this patch is important and should go in very soon. The code
> looks
> > good to me, and I've successfully tested with it several times.
> >
> > Are there any outstanding issues or patches that should be submitted
> first?
> >
>
> Error recovery from a failed erase could be better, but it is pretty
> much on par with the current code.
>
> I have some cleanups and patches for better error recovery which
> conflict with this patch, but they shouldn't hold this patch back. I
> hope to resend them immediately after this patch is merged (and some of
> them will be tiny afterwards).
>
> To summarize, I think nothing else is left to do before committing this
> patch.
>

Alrighty then! I've stared at the code as much as my eyes will allow and
have tested it on a couple different platforms with SPI flash (AMD870 and
Intel NM10), so:

Acked-by: David Hendricks <dhendrix at google.com>

Idwer's been doing a lot with this patch too, so you might want to wait for
his ack as well.

-- 
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20101101/d929900e/attachment.html>


More information about the flashrom mailing list