[flashrom] [PATCH] Torture script fixes

David Hendricks dhendrix at google.com
Mon Nov 1 23:37:00 CET 2010


On Mon, Nov 1, 2010 at 3:30 PM, Idwer Vollering <vidwer at gmail.com> wrote:

> 2010/11/1 David Hendricks <dhendrix at google.com>
>
> On Sat, Oct 30, 2010 at 12:43 AM, Paul Menzel <
>> paulepanter at users.sourceforge.net> wrote:
>>
>>> Am Samstag, den 30.10.2010, 02:16 +0200 schrieb Carl-Daniel Hailfinger:
>>> > Use mktemp unconditionally for security reasons.
>>> > Avoid non-portable seq.
>>> >
>>> > Signed-off-by: Carl-Daniel Hailfinger <
>>> c-d.hailfinger.devel.2006 at gmx.net>
>>>
>>
> Acked-by: Idwer Vollering <vidwer at gmail.com>
>
>
>>  >
>>> > Index:
>>> flashrom-torturescript_portability/util/flashrom_partial_write_test.sh
>>> > ===================================================================
>>> > ---
>>> flashrom-torturescript_portability/util/flashrom_partial_write_test.sh
>>>  (Revision 1219)
>>> > +++
>>> flashrom-torturescript_portability/util/flashrom_partial_write_test.sh
>>>  (Arbeitskopie)
>>> > @@ -34,8 +34,12 @@
>>> >  echo "testing flashrom binary: ${FLASHROM}"
>>> >
>>> >  OLDDIR=$(pwd)
>>> > -if [ -z "$TMPDIR" ]; then
>>> > -     TMPDIR=$(mktemp -d)     # test data location
>>> > +
>>> > +# test data location
>>> > +TMPDIR=$(mktemp -d -t flashrom_test.XXXXXXXXXX)
>>> > +if [ "$?" != "0" ] ; then
>>> > +     echo "Could not create temporary directory"
>>>
>>> Full stop at the end.
>>>
>>> Is `mktemp` always installed? If not will there be an error message –
>>> passed down from Bash – indicating that it needs to be installed?
>>>
>>
> It is safe to assume it is.
>

To elaborate, "mktemp" is part of the GNU coreutils package, which is pretty
much mandatory on GNU/Linux distros:

Ubuntu example:
dhendrix at amd870:~$ dpkg -S `which mktemp`
coreutils: /bin/mktemp

Gentoo example:
(cros-chroot) dhendrix at thegates ~ $ equery belongs `which mktemp`
 * Searching for /usr/bin/mktemp ...
sys-apps/coreutils-7.5-r1 (/bin/mktemp)
sys-apps/coreutils-7.5-r1 (/usr/bin/mktemp -> /bin/mktemp)


-- 
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20101101/e0f16f47/attachment.html>


More information about the flashrom mailing list