[flashrom] [PATCH 3/3] Unify board info handling

[Peter Lemenkov]

Hello!

2010/5/27 Uwe Hermann <uwe at hermann-uwe.de>:

> We need to explicitly list the numbers of (1) supported, (2) unsupported
> boards (at least) here, the total number of "known" boards alone is not
> useful and will confuse users.

Done.

> Please check the "flashrom -L" output, I think the last column output is
> not always correctly aligned.

I improved column alignment a bit.

> Also, maybe change "Write-enable option?" to "Required option:".

Done.

> I'd prefer "OK / BROKEN" or "OK / --BAD--" or something like that here,
> but definately "OK" for the good boards, to be consistent.

Ok. I'm using OK/BAD for now.

> Hm, actually "BAD" is not quite correct, it's more like "UNTESTED", the
> board-enable may very well work fine, it's just not yet tested.
> Do you differ between actually broken and just untested in the
> tables/code?

No, I don't differ them. I just copypasted what was in flashrom
sources previously, and there are only wonking/non-working boards
listed there.

> Minor nitpick for the table:
> To save horizontal space, maybe change "BOARD_ENTRY" to "B", doesn't
> have to be really readable here, the table entries and header comment
> speak for themselves in this case (IMHO).

Done.

> Tabs for separating the first few entries is OK, but I'd use exactly one
> space (not tab) after the "OK" entry and after the URL. Alignment will
> automatically still be enforced for those columns where it's possible
> (reasonably). The URL / comment fields don't make much sense to try to
> align them and the tabs there just waste horizontal space.

Done.

> Please check the wiki output (flashrom -z), it's partly broken right
> now.

Fixed.

New version of patch attached.


-- 
With best regards, Peter Lemenkov.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Unify-board-info-handling.patch
Type: application/octet-stream
Size: 64181 bytes
Desc: not available
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100531/859cc3e8/attachment.obj>