[flashrom] [PATCH] Support for HP DL165 G6

[Michael Karcher]

Am Mittwoch, den 26.05.2010, 16:08 +0200 schrieb Arne Georg Gleditsch:
> On 26. mai 2010 15:56, Michael Karcher wrote:
> > Try to find an lspci dump of that DL145 and check whether some PCI
> > signature is different. If not, check whether DMI contains some string

> As Google has it, it would appear that the onboard NIC is different:
> 
> DL145:
> 08:04.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5715 Gigabit Ethernet [14e4:1678] (rev a3)
> 08:04.1 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5715 Gigabit Ethernet [14e4:1678] (rev a3)
> 
> DL165:
> 02:02.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5704 Gigabit Ethernet [14e4:1648] (rev 10)
> 02:02.1 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5704 Gigabit Ethernet [14e4:1648] (rev 10)
> 
> Perhaps that could be used for the secondary PCI device in the signature?
> I believe the device currently listed there is the on-board VGA chip; I'm
> not sure why that was chosen.

Maybe because we preferrably choose chips with subsystem IDs. Maybe
because someone thought that a new board revision very probably contains
a more modern graphics chip. In this case, you are very right in
suggesting to take the network chip as secondary PCI ID. You need to
find out what subsystem IDs are used (if any) in the DL145 and the
DL165.

If you send
 - lspci -vvvxxxnn, superiotool -deV and flashrom -V output of your
DL165 (general requirement for having new boards added),
 - an updated patch that uses the network instead of the graphics chip
for both boards, including a sign-off[1],
 - preferably at least PCI ID info including subsystems for the DL145,

your patch is in my oppinion ready to be added to flashrom.

Regards,
  Michael Karcher

[1]: http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure