[flashrom] [PATCH] support for NIC RTL8139 onboard flashing

[Jörg Fischer]

Hi,
Carl-Daniel Hailfinger schrieb:
> Hi Jörg,
> 
> thank you for the patch.
> 
> On 19.05.2010 01:51, Jörg Fischer wrote:
>> Jörg Fischer schrieb:
>>
>>   
>>> here is the patch for RTL1839 based NICs.
>>>     
>> And here is the second version, which works. It should be applied to
>> a clean svn, without my first patch.

And here is the 3rd...

>>> It is disabled by default in the Makefile.
>>>     
> 
> Should we still disable it by default? You said it works now, and all
> working drivers should be enabled by default IMHO.

Was a bit surprised that I got it working...
But yes, it is enabled now.

>> And another point: I read somewhere that RTL8139D and later Chips may
>> not have Flash Writing capability anymore. Read: no newer Cards :-(
>>   
> 
> That's unfortunate, but now we can support at least those chips which
> can write.

FYI: The cards that can and the cards that cannot write may have the
very same PCI ID.

> I noticed the double init functions caused by a suboptimal interface of
> pcidev_init. I will change that later, but for now your patch will get
> merged as is.

Another thing that came to my mind: There may be multiple "Cards" with
the same PCI ID, and I have not found a way to select one (e.g. via
command line paramater) in this case.
One set of Mainboards I saw has one RTL chip onboard, but for flash I
wanted to use the external card.

> Is it intentional that the copyright says "TURBO J"? I think your
> drkaiser driver has your name in the copyright line.

No, it should have read "Joerg Fischer <turboj at gmx.de>", sorry.

Corrected patch is attached.

-- Jörg Fischer

Signed-off-by: Joerg Fischer <turboj at gmx.de>

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: nicrealtek2.patch
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100519/662814f9/attachment.ksh>