[flashrom] [patch] add version information similar to 'uname -mrs'

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Mar 23 05:27:57 CET 2010


Sorry for the slightly trimmed mail.

On 23.03.2010 05:19, Carl-Daniel Hailfinger wrote:
> OK, here's a patch which uses code from Idwer Vollering and Maciej
> Pijanka. I've added Makefile support and compiler version printing and
> restructured the code heavily.
> The code prints runtime system information and buildtime libpci
> information (I couldn't find any runtime libpci version function). Due
> to our ability to cross-compile flashrom, buildtime system information
>   

from "uname -mrs" doesn't help diagnosing any problems. That's why only
libpci and gcc are buildtime info, and the rest is runtime info.

> Examples:
> With PCI support:
> flashrom v0.9.1-r971 on Linux 2.6.27.29-0.1-default (x86_64), built with
> libpci 3.0.1, GCC 4.3.2 [gcc-4_3-branch revision 141291]
> flashrom v0.9.1-r971 on Linux 2.6.22.19-0.2-default (i686), built with
> libpci 2.2.6, GCC 4.2.1 (SUSE Linux)
> flashrom v0.9.1-r971 on Linux 2.6.22.19-0.2-default (i686), built with
> libpci 2.2.6, GCC 4.2.1 Compatible Clang Compiler
>
> Without PCI support:
> flashrom v0.9.1-r971 on Linux 2.6.27.29-0.1-default (x86_64), GCC 4.3.2
> [gcc-4_3-branch revision 141291]
> flashrom v0.9.1-r971 on Linux 2.6.22.19-0.2-default (i686), GCC 4.2.1
> (SUSE Linux)
> flashrom v0.9.1-r971 on Linux 2.6.22.19-0.2-default (i686), GCC 4.2.1
> Compatible Clang Compiler
>   

The wording could probably be better. Suggestions welcome.

> Idwer and Maciej, feel free to re-add your signoffs to this patch. I was
> unsure whether you would be OK with my variant, so I left out your signoffs.
>
> Reviews appreciated, especially about the compiler part. I think this
> can be valuable (e.g. if someone compiles with clang and triggers the
> clang/flashrom miscompile), but I'm unsure if/how this works on Windows
> and DOS. I tried to make it non-explosive, but...
>
> Output from "flashrom --version" for non-Linux platforms and unusual
> compilers would be appreciated.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>   

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list